chore: review DialTextarea props and use TextareaHTMLAttributes<HTMLTextAreaElement>#458
Draft
PolinaGurinovich97 wants to merge 6 commits intodevelopmentfrom
Draft
chore: review DialTextarea props and use TextareaHTMLAttributes<HTMLTextAreaElement>#458PolinaGurinovich97 wants to merge 6 commits intodevelopmentfrom
PolinaGurinovich97 wants to merge 6 commits intodevelopmentfrom
Conversation
hhharmEpm
reviewed
Jan 27, 2026
| disabled, | ||
| invalid, | ||
| readonly, | ||
| containerClassName = '', // TODO: Use? |
Contributor
There was a problem hiding this comment.
Currently It's used in use cases admin when text area need to grow to the container size. It's use is demonstrated in story FullParentHeightWithScroll of TextAreaField
You can try to comment out this prop and see that text area doesn't grow to parent height anymore and there is no other way to do this
valerydluski
reviewed
Feb 2, 2026
| Omit<TextareaHTMLAttributes<HTMLTextAreaElement>, 'onChange'>, | ||
| HTMLTextAreaElement | ||
| > { | ||
| containerClassName?: string; // TODO: need? |
Contributor
There was a problem hiding this comment.
You can reuse the same approach as in the IconButton implementation (see the pattern around line 62) for passing/handling tooltip props, to keep the behavior consistent:
https://github.com/epam/ai-dial-ui-kit/blob/development/src/components/IconButton/IconButton.tsx#L62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…extAreaElement>
Description:
<SHORT_DESCRIPTION>
Issues:
UI changes
<Please, provide Screenshots or Figma links>
Checklist:
fix:,feat:,feature:,chore:,hotfix:ore2e:. If contains breaking changes then the pull request name must start withfix!:,feat!:,feature!:,chore!:,hotfix!:ore2e!:.(Issue #<TICKET_ID>)(comma-separated list of issues)New Component Checklist:
e.g.
import { Button } from '@/components/Button/Buttoninstead ofimport { Button } from '../../Button/Button