Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: support disabling cert-gen job #3501

Closed
gecube opened this issue May 29, 2024 · 5 comments
Closed

helm: support disabling cert-gen job #3501

gecube opened this issue May 29, 2024 · 5 comments
Assignees
Labels
wontfix This will not be worked on
Milestone

Comments

@gecube
Copy link

gecube commented May 29, 2024

Good day!

I see that inside of helm chart we are using kind: Job to generate certificates. I'd like to ask to support disabling of this job as I can issue these certificates with cert-manager like I proposed in another project wazuh/wazuh-kubernetes#577

@gecube gecube added the triage label May 29, 2024
@arkodg
Copy link
Contributor

arkodg commented May 29, 2024

hey @gecube we highlight this integration in https://gateway.envoyproxy.io/v1.0.1/install/custom-cert/, in this case the job is a no-op, we can do better by adding explicit support to disable the job in helm

@gecube
Copy link
Author

gecube commented May 29, 2024

@arkodg Hi! Thanks, I already found this article on my own. It was tough, but anyway appreciate your fast reply.

we can do better by adding explicit support to disable the job in helm

super idea!!!!

@arkodg arkodg changed the title certgen - switch to cert-manager helm: support disabling cert-gen job May 29, 2024
@arkodg arkodg added help wanted Extra attention is needed and removed triage labels May 29, 2024
@arkodg arkodg added this to the Backlog milestone May 29, 2024
@ShyunnY
Copy link
Contributor

ShyunnY commented May 30, 2024

It looks like we need to add a knob to turn/off, I think I should be able to complete this work. :)

@arkodg arkodg removed the help wanted Extra attention is needed label May 30, 2024
@arkodg
Copy link
Contributor

arkodg commented May 30, 2024

thanks for picking this one up @ShyunnY,


thinking out loud, one UX in Helm for this could be

certgen: nil

@arkodg
Copy link
Contributor

arkodg commented Jun 15, 2024

Disabling the cert-get job may also impact other features like OIDC, and it may be hard to make the user aware of this for such cases.
Since running the cert-gen job for this above case is a no-op, we prefer to keep in on, and skip generating certs for this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants