Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certgen optional in helm chart #4530

Closed
lsjostro opened this issue Oct 25, 2024 · 1 comment
Closed

Make certgen optional in helm chart #4530

lsjostro opened this issue Oct 25, 2024 · 1 comment
Labels

Comments

@lsjostro
Copy link
Contributor

Description:
Would be nice to make certgen optional in helm chart. (have job resource wrapped with a conditional like certgen.enabled: true/false maybe?)

little silly having to patch away within kustomize like so:
image

@arkodg
Copy link
Contributor

arkodg commented Oct 25, 2024

hey @lsjostro we had discussed this earlier in #3501 and decided to not support a disable knob because the job also creates some secrets needed for OIDC.
If the secrets (for certs or hmac) already exist (if you are setting your own control auth certs), then the cert gen job will skip creating any new secrets (a no-op)

@arkodg arkodg closed this as completed Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants