Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump rules_rust -> 0.54.1 #37056

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Fix #37054

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 8, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #37056 was opened by dependency-envoy[bot].

see: more, trace.

@phlax
Copy link
Member

phlax commented Nov 8, 2024

this breaks the crates setup - cc @mathetake

@phlax phlax changed the title deps: Bump rules_rust -> 0.54.1 [WIP] deps: Bump rules_rust -> 0.54.1 Nov 8, 2024
@phlax phlax marked this pull request as draft November 8, 2024 10:28
@mathetake
Copy link
Member

CARGO_BAZEL_REPIN=1 bazel sync --only=crate_index would help to update the lCargo.Bazel.lock file - could you try?

@phlax
Copy link
Member

phlax commented Nov 8, 2024

thanks @mathetake that worked - ive added an update message also

@phlax phlax changed the title [WIP] deps: Bump rules_rust -> 0.54.1 deps: Bump rules_rust -> 0.54.1 Nov 8, 2024
@phlax phlax marked this pull request as ready for review November 8, 2024 19:59
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 8, 2024
@phlax phlax enabled auto-merge (squash) November 8, 2024 20:01
@mathetake
Copy link
Member

glad it worked!

@phlax
Copy link
Member

phlax commented Nov 8, 2024

/retest rbe auth fail

@phlax
Copy link
Member

phlax commented Nov 8, 2024

/retest

@phlax phlax merged commit 019f589 into main Nov 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newer release available rules_rust: 0.54.1 (current: 0.53.0)
3 participants