Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: add support for matching on route metadata #36957

Merged
merged 21 commits into from
Nov 9, 2024

Update api/envoy/config/rbac/v3/rbac.proto

b6d8bca
Select commit
Loading
Failed to load commit list.
Merged

rbac: add support for matching on route metadata #36957

Update api/envoy/config/rbac/v3/rbac.proto
b6d8bca
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS tests skipped Nov 9, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36957/main@b6d8bca)

agrawroh @agrawroh b6d8bca #36957 merge main@8ef1ecc

rbac: add support for matching on route metadata

Background

This PR adds a new option called sourced_metadata to RBAC permissions and principals which allows specifying an optional source for the metadata to be matched. Currently it only supports Dynamic Metadata and Route Metadata. More options could be added later.

Fixes: #34913


Commit Message: rbac: add support for matching on route metadata
Additional Description: This PR adds a new option called sourced_metadata to RBAC permissions and principals which allows specifying an optional source for the metadata to be matched.
Risk Level: Low
Testing: Added Unit & Integration Tests
Docs Changes: Added
Release Notes: Added

Environment

Request variables

Key Value
ref 99d74a5
sha b6d8bca
pr 36957
base-sha 8ef1ecc
actor agrawroh @agrawroh
message rbac: add support for matching on route metadata...
started 1731131587.666132
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true