Skip to content

Commit

Permalink
revert adding sni to example/docs in one case as per review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Greg Greenway <[email protected]>
  • Loading branch information
ggreenway committed Nov 8, 2024
1 parent 4699715 commit cc03ba4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ static_resources:
name: envoy.transport_sockets.tls
typed_config:
"@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
sni: proxy-postgres-backend.example.com
common_tls_context:
validation_context:
trusted_ca:
Expand Down
8 changes: 4 additions & 4 deletions docs/root/start/quick-start/securing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ Firstly, you can ensure that the certificates are from a mutually trusted certif
:language: yaml
:linenos:
:lineno-start: 42
:lines: 42-53
:emphasize-lines: 9-12
:lines: 42-52
:emphasize-lines: 8-11
:caption: :download:`envoy-demo-tls-validation.yaml <_include/envoy-demo-tls-validation.yaml>`

You should also ensure that the Subject Alternative Names (SANs) for the certificate match.
Expand All @@ -104,8 +104,8 @@ followed by ``match_typed_subject_alt_names``.
:language: yaml
:linenos:
:lineno-start: 44
:lines: 44-55
:emphasize-lines: 6-7, 11-12
:lines: 44-54
:emphasize-lines: 6-7, 10-11
:caption: :download:`envoy-demo-tls-validation.yaml <_include/envoy-demo-tls-validation.yaml>`


Expand Down

0 comments on commit cc03ba4

Please sign in to comment.