Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new icons #3776

Merged
merged 42 commits into from
Oct 28, 2024
Merged

Add new icons #3776

merged 42 commits into from
Oct 28, 2024

Conversation

LeGenDaRy15PT
Copy link
Contributor

@LeGenDaRy15PT LeGenDaRy15PT commented Oct 20, 2024

Add new icons

@LeGenDaRy15PT LeGenDaRy15PT changed the title Add new icon Add news icons Oct 20, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2024

CLA assistant check
All committers have signed the CLA.

@LeGenDaRy15PT LeGenDaRy15PT changed the title Add news icons Add new icons Oct 20, 2024
@tanguylegazon
Copy link
Contributor

Hey @LeGenDaRy15PT 👋

That’s quite a bit of work you’ve done!

The Minecraft SVG looks a bit off to me—did you use an image-to-vector converter for it? If so, you might want to try this version instead: https://svgur.com/i/W65.svg (although I haven’t checked for any potential licensing restrictions).

Also, the Steam logo you used is actually the app icon, not the official brand logo. According to the official branding guidelines, the Steam logo should be monochromatic. I’d suggest reverting the changes for this one to follow the guidelines.

Thanks for all the effort!

@LeGenDaRy15PT
Copy link
Contributor Author

Hello @tanguylegazon 👋

I'll make these changes now, thanks for letting me know
You're welcome, whatever I can help with to complete this application, I will do so 👍

@tanguylegazon
Copy link
Contributor

It might be preferable to revert to the original setup for the Steam logo by removing Steam.svg and the corresponding entry in custom-icons.json. This approach would have a few benefits:

  • The logo could then be sourced directly from the simple-icons library, allowing us to:
    • Avoid duplicates in the repo
    • Skip any maintenance for the logo
  • The logo would also automatically adjust to light and dark themes within the app

In general, it’s best to avoid adding a logo to the project if it’s already available in the simple-icons library, follows brand guidelines, and displays well in the Auth app.

@LeGenDaRy15PT
Copy link
Contributor Author

I've already removed the Steam logo

@ua741 ua741 merged commit a6e4f9e into ente-io:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants