Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert platform detection in HTML #12082

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Revert platform detection in HTML #12082

merged 1 commit into from
Jan 20, 2025
+5 −0

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 20, 2025 •
edited
Loading

Pull Request Description

This PR addresses the bug introduced in #11337, which occurred when the code responsible for detecting the platform was removed. Consequently, the text alignment within the grid became incorrect.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Jan 20, 2025
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug g-dashboard labels Jan 20, 2025
@github-actions GitHub Actions
Copy link

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount changed the title revert platform detection in HTML Revert platform detection in HTML Jan 20, 2025
@MrFlashAccount MrFlashAccount merged commit 1625112 into develop Jan 20, 2025
41 of 43 checks passed
@MrFlashAccount MrFlashAccount deleted the wip/sergeigarin/revert-platform-detection branch January 20, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@PabloBuchu PabloBuchu PabloBuchu approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@somebody1234 somebody1234 Awaiting requested review from somebody1234 somebody1234 is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels
--bug Type: bug CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrFlashAccount @PabloBuchu @farmaazon