Refactoring in preparation for normalized qualified names #11927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `SuggestionUpdateProcessor` will simplify adding more contextual information to the update application process. - Mock suggestion data is constructed using `lsUpdate` so that the mocking logic doesn't have to be kept consistent with the `lsUpdate` implementation. - When uploading, use `ExternalId` to identify function; it's simpler than comparing stack items. - Correct some language server definitions that can be `null` in practice. - Add a test covering *current* behavior wrt. #11815; following PR will update expected results.
kazcw
added
the
CI: No changelog needed
🧪 Storybook is successfully deployed!📊 Dashboard:
|
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
farmaazon
approved these changes
Jan 2, 2025
Comment on lines
+16
to
+18
| defaultValue?: string | null | ||
| /** Optional list of possible values that this argument takes. */ | ||
| tagValues?: string[] | ||
| tagValues?: string[] | null |
There was a problem hiding this comment.
These structures reflect their protocol definitions and I would consider leaving them this way. If someone would in the future send SuggestionEntryArgument to LS with nulls, those will be rejected by engine. On the other hand, there's currently no such endpoint in LS, so I leave this decision to you.
There was a problem hiding this comment.
This change is for consistency with the protocol implemented by the Language Server. I opened a bug about the current protocol's inconsistency with the documentation: #11964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Part of #11815: Some refactoring before introducing any behavior changes.
SuggestionUpdateProcessorwill simplify adding more contextual information to the update application process.lsUpdateso that the mocking logic doesn't have to be kept consistent with thelsUpdateimplementation.ExternalIdto identify function; it's simpler than comparing stack items.nullin practice.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.