Treat data links even more like symlinks, allow crossing using /
#11926
Conversation
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
…x faster for data links cases)
This reverts commit 7668476.
|
Running extra tests as this affects Cloud and S3:
|
| is_directory_builtin file = @Builtin_Method "File.is_directory_builtin" | ||
|
|
||
| is_regular_file_builtin file = @Builtin_Method "File.is_regular_file_builtin" |
There was a problem hiding this comment.
Very nice list of builtins. Thank you!
| @@ -1,3 +1,50 @@ | |||
| private | |||
There was a problem hiding this comment.
And they are all in a private module. Great.
| under a given directory key. This method, however, will only return true if | ||
| an object with the exact key exists and is not just an empty marker (as used | ||
| sometimes to mark directories). | ||
| exists_entity_direct (f : S3_File) -> Boolean = |
There was a problem hiding this comment.
This means a user cannot store an object that happens to be zero length, and then verify that it exists. Perhaps we should just treat directory markers are existing objects. I realize there's no good solution to this. But this approach means that if a user creates objects and checks for their existence, they have to know that they cannot do it with one that happens to be empty.
There was a problem hiding this comment.
This check is only used in the is_data_link logic, only if the object's name ends with .datalink. It is needed to distinguish a datalink file (which if not malformed, should never be empty) from a directory marker.
This check is not done on non-data link entities at all, the exists method is using a different implementation for regular files/directories. Perhaps I should add a comment to the method that it is only a helper for the datalink heuristic.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.