Widget support for Data.fetch and Data.post. #11199

jdunkerley · 2024-09-27T12:56:17Z

Pull Request Description

Add pretty for Date and Time.
Add constructors for JS_Object and Dictionary to the component browser.
Add widgets to Dictionary methods.
Add conversion from Vector to Dictionary.
Add pair method shorthand for Pair.Value.
Created widget for Header.
Added widgets for Data.fetch and Data.post.
Added widgets for Request_Body constructors.
Update the Forbidden Operation message to be friendlier.

Video before fixing Forbidden Message:

2024-09-27_10-44-26.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.

Widgets for all of Dictionary.

hubertp

Approving engine changes

GregoryTravis · 2024-09-27T13:47:10Z

distribution/lib/Standard/AWS/0.0.0-dev/src/Internal/S3_File_Write_Strategy.enso

@@ -16,7 +16,7 @@ instance =
 ## PRIVATE
 create_dry_run_file file copy_original =
    _ = [file, copy_original]
-    Error.throw (Forbidden_Operation.Error "Currently dry-run is not supported for S3_File, so writing to an S3_File is forbidden if the Output context is disabled.")
+    Error.throw (Forbidden_Operation.Error "As writing is disabled, no action has been performed. Press the Write button ▶ to write the file.")


This could be a helper in Context since it's repeated so much.

distribution/lib/Standard/AWS/0.0.0-dev/src/S3/S3_File.enso

JaroslavTulach · 2024-09-27T13:46:05Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Dictionary.enso

@@ -32,14 +38,12 @@ from project.Data.Text.Extensions import all
   to pass a foreign map into Enso, where it will be treated as a Dictionary.
 @Builtin_Type
 type Dictionary key value
-    ## PRIVATE
-       ADVANCED
+    ## ICON array_new2


Unrelated: Why is the ICON called array_new2?

Just the name in figma, there are a few "array_new" variants.

JaroslavTulach · 2024-09-27T13:58:32Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Dictionary.enso

@@ -423,3 +439,19 @@ type Dictionary key value
    ## PRIVATE
    get_builtin : Any -> Any -> Any
    get_builtin self key ~if_missing = @Builtin_Method "Dictionary.get_builtin"
+
+## PRIVATE
+key_widget dict:Dictionary -> Widget =


Can these methods be moved into their own private helper module?

We often need to get the widgets in other functions so tend to keep them as ## PRIVATE methods in the module.

JaroslavTulach · 2024-09-27T13:59:44Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Dictionary.enso

    insert : Any -> Any -> Dictionary
-    insert self key value = @Builtin_Method "Dictionary.insert"
+    insert self key=(Missing_Argument.throw "key") value=(Missing_Argument.throw "value") =
+        self.insert_builtin key value


Is the insert_builtin method defined nowhere? Autoregistered? I'd make it static, put it into a private helper module.

It's auto-registered the same as the "remove_builtin" - we should do a review of what we need to do with the builtins to make it the best set up whenever suits you.

the request to hide builtin methods is tracked as Builtin methods shall not be publicly visible #6282

JaroslavTulach · 2024-09-27T14:00:16Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Pair.enso

@@ -295,3 +295,12 @@ check_start_valid start function max=3 =
    used_start = if start < 0 then start + 2 else start
    if used_start < 0 || used_start >= max then Error.throw (Index_Out_Of_Bounds.Error start max) else
        function used_start
+
+## ICON array_new


ICON array_new? What's the difference to array_new2?

Slightly different look...

JaroslavTulach · 2024-09-27T14:02:22Z

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date.enso

+    ## PRIVATE
+       Convert to a Enso code representation of this Date.
+    pretty : Text
+    pretty self = "(Date.new " + self.year.to_text + " " + self.month.to_text + " " + self.day.to_text + ")"


Eh! Another way to persist a value.

Wouldn't it be better to have type Code and then conversions to instances of the Code type? Because right now you get a code, but you may not have the right imports! Code could carry both - the imports and the code to construct the instance.

This is matching our current pretty methods which work for some types, we can happily review and work out what we should do longer term.

- Add `pretty` for `Date` and `Time`. - Add constructors for `JS_Object` and `Dictionary` to the component browser. - Add widgets to `Dictionary` methods. ![image](https://github.com/user-attachments/assets/4f6c58d5-9eb5-40e5-96c1-2e06e23051d0) - Add conversion from Vector to Dictionary. - Add `pair` method shorthand for `Pair.Value`. - Created widget for `Header`. - Added widgets for `Data.fetch` and `Data.post`. - Added widgets for `Request_Body` constructors. - Update the Forbidden Operation message to be friendlier. ![image](https://github.com/user-attachments/assets/eaac5def-a91f-450f-b814-d776311962e3) Video before fixing Forbidden Message: https://github.com/user-attachments/assets/f9c4bde4-3f0a-49f1-a3ca-a0aaa3219286 (cherry picked from commit 28bbc34)

jdunkerley added 7 commits September 27, 2024 09:09

WIP

beff637

Initial widget work on JS_Object and Dictionary.

9bf2f82

Add pretty for Date and Time_Of_Day.

0093588

Widgets for all of Dictionary.

Rename insert to insert_builtin to make widgets work.

a34b24d

Add headers widget.

754e871

Update Request_Body to have widgets and be usable.

78440c2

Forbidden messages.

1283888

jdunkerley marked this pull request as ready for review September 27, 2024 13:27

jdunkerley requested review from radeusgd, GregoryTravis, AdRiley, marthasharkey, 4e6, JaroslavTulach, hubertp and Akirathan as code owners September 27, 2024 13:27

jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 27, 2024

hubertp approved these changes Sep 27, 2024

View reviewed changes

marthasharkey approved these changes Sep 27, 2024

View reviewed changes

GregoryTravis approved these changes Sep 27, 2024

View reviewed changes

JaroslavTulach approved these changes Sep 27, 2024

View reviewed changes

jdunkerley added 3 commits September 27, 2024 16:20

Fix Header widget.

42c65b3

Fix failing test.

719bf5a

Fix failing test.

2580bb8

jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Sep 27, 2024

mergify bot merged commit 28bbc34 into develop Sep 27, 2024
42 checks passed

mergify bot deleted the wip/jd/make-post-easier branch September 27, 2024 18:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Widget support for Data.fetch and Data.post. #11199

Widget support for Data.fetch and Data.post. #11199

jdunkerley commented Sep 27, 2024 •

edited

Loading

hubertp left a comment

GregoryTravis Sep 27, 2024

JaroslavTulach Sep 27, 2024

jdunkerley Sep 27, 2024

JaroslavTulach Sep 27, 2024

jdunkerley Sep 27, 2024

JaroslavTulach Sep 27, 2024

jdunkerley Sep 27, 2024

JaroslavTulach Sep 29, 2024

JaroslavTulach Sep 27, 2024

jdunkerley Sep 27, 2024

JaroslavTulach Sep 27, 2024

jdunkerley Sep 27, 2024

Widget support for Data.fetch and Data.post. #11199

Widget support for Data.fetch and Data.post. #11199

Conversation

jdunkerley commented Sep 27, 2024 • edited Loading

Pull Request Description

Important Notes

Checklist

hubertp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdunkerley commented Sep 27, 2024 •

edited

Loading