Skip to content

Commit

Permalink
fix generated icon file imports and add compilation step to e2e
Browse files Browse the repository at this point in the history
  • Loading branch information
Frizi committed Dec 19, 2024
1 parent 40f2820 commit c7b3f07
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/gui-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ jobs:
fail-fast: false
max-parallel: 24
matrix:
shardIndex: [1, 2, 3, 4, 5, 6]
shardTotal: [6]
shardIndex: [1, 2, 3, 4]
shardTotal: [4]

steps:
- uses: actions/checkout@v4
Expand All @@ -143,6 +143,10 @@ jobs:
- name: 📺 Install Playwright Browsers
working-directory: app/gui
run: pnpm run playwright:install

- name: ⚙️ Compile
id: compile
run: pnpm run compile

- name: 🎭 Playwright Tests
working-directory: app/gui
Expand Down
2 changes: 1 addition & 1 deletion app/gui/src/project-view/components/StandaloneButton.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script setup lang="ts">
import type { URLString } from '@/util/data/urlString'
import type { Icon } from '@/util/iconName'
import type { Icon } from '@/util/iconMetadata/iconName'
import SvgButton from './SvgButton.vue'
const props = defineProps<{
Expand Down
2 changes: 1 addition & 1 deletion app/gui/src/project-view/util/button.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type Icon } from '@/util/iconName'
import { type Icon } from '@/util/iconMetadata/iconName'
import { computed, type ComputedRef, markRaw, type MaybeRef, type Ref, unref } from 'vue'

export type ActionOrStateRequired = { action: () => void } | { state: Ref<boolean> }
Expand Down
2 changes: 1 addition & 1 deletion app/gui/src/project-view/util/tabs.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Icon } from '@/util/iconMetadata/iconName'
import { assert } from './assert'
import { Icon } from './iconName'

export type TabButton<T> = { tab: T; title: string; icon: Icon }
export type ExtractTabs<Buttons> = Buttons extends TabButton<infer T>[] ? T : never
Expand Down

0 comments on commit c7b3f07

Please sign in to comment.