Skip to content

Commit

Permalink
Reenable test
Browse files Browse the repository at this point in the history
  • Loading branch information
AdRiley committed Dec 17, 2024
1 parent 0e6d032 commit 5430da2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ type SQLServer_Dialect
Last _ _ _ _ -> unsupported "Last"
Maximum _ _ -> True
Minimum _ _ -> True
Shortest _ _ -> True
Longest _ _ -> True
Shortest _ _ -> unsupported "Shortest"
Longest _ _ -> unsupported "Longest"
Standard_Deviation _ _ _ -> True
Concatenate _ _ _ _ _ _ -> True
Sum _ _ -> True
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ add_aggregate_specs suite_builder setup =
problems.at 0 . location . should_equal "Float"

if is_database then
suite_builder.group prefix+"Table.aggregate should report unsupported operations but not block other aggregations in warning mode" pending="TODO" group_builder->
suite_builder.group prefix+"Table.aggregate should report unsupported operations but not block other aggregations in warning mode" group_builder->
expect_sum_and_unsupported_errors error_count result = within_table result <|
result.column_count . should_equal 1
result.row_count . should_equal 1
Expand Down Expand Up @@ -1730,7 +1730,7 @@ add_aggregate_specs suite_builder setup =
expect_sum_and_unsupported_errors 2 <|
table.aggregate columns=[Sum "X", Shortest "Y", Longest "Y"]

if test_selection.text_concat.not && (setup.prefix.contains "Snowflake" . not) then
if test_selection.text_concat.not && (setup.prefix.contains "Snowflake" . not && setup.prefix.contains "SQLServer" . not) then
group_builder.specify "with Concatenate" <|
table = table_builder [["X", [1,2,3]], ["Y", ["a", "bb", "ccc"]]]
expect_sum_and_unsupported_errors 1 <|
Expand Down

0 comments on commit 5430da2

Please sign in to comment.