Merge pull request #156 from enrique-lozano/feat/ui-improvements

Remove the filled color on the dashboard header trending value
enrique-lozano · May 1, 2024 · eeed4d4 · eeed4d4
2 parents df82ec0 + 55675b7
commit eeed4d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/app/home/dashboard.page.dart b/lib/app/home/dashboard.page.dart
@@ -253,9 +253,8 @@ class _DashboardPageState extends State<DashboardPage> {
 
                                         return TrendingValue(
                                           percentage: snapshot.data!,
-                                          filled: true,
                                           fontWeight: FontWeight.bold,
-                                          outlined: true,
+                                          fontSize: 16,
                                         );
                                       },
                                     ),

diff --git a/lib/core/presentation/widgets/trending_value.dart b/lib/core/presentation/widgets/trending_value.dart
@@ -1,6 +1,6 @@
 import 'package:flutter/material.dart';
-import 'package:monekin/core/presentation/widgets/number_ui_formatters/ui_number_formatter.dart';
 import 'package:monekin/core/extensions/color.extensions.dart';
+import 'package:monekin/core/presentation/widgets/number_ui_formatters/ui_number_formatter.dart';
 
 import '../app_colors.dart';
 
@@ -59,7 +59,11 @@ class TrendingValue extends StatelessWidget {
 
   Color _getColorBasedOnPercentage(BuildContext context) {
     return percentage == 0
-        ? AppColors.of(context).brand.lighten(0.35).withBlue(225)
+        ? AppColors.of(context)
+            .brand
+            .lighten(
+                Theme.of(context).brightness == Brightness.dark ? 0.45 : 0.25)
+            .withBlue(225)
         : percentage > 0
             ? AppColors.of(context).success
             : AppColors.of(context).danger;