Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications to buds plugin and more #872

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

Add notifications to buds plugin and more #872

wants to merge 1 commit into from

Conversation

grazzolini
Copy link
Contributor

  • Added notifications when battery drift occurs and when one of the buds is on the case, when they reach same battery level.
  • The notifications can be disabled by a configuration option.
  • The symbols used to indicate the buds placement can be changed. We use regular characters, but printable unicode characters can be used too.
  • Some code was refactored into functions to cleanup run()
  • The tests were changed for the symbol change. Also a few tests for the notifications were added. Also, a few tests were extended to make sure the code changing the symbols work.

@grazzolini
Add notifications to buds plugin and more
e69799c 
* Added notifications when battery drift occurs and when one of the buds is on the case, when they reach same battery level.
* The notifications can be disabled by a configuration option.
* The symbols used to indicate the buds placement can be changed. We use regular characters, but printable unicode characters can be used too.
* Some code was refactored into functions to cleanup run()
* The tests were changed for the symbol change. Also a few tests for the notifications were added. Also, a few tests were extended to make sure the code changing the symbols work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grazzolini