core/__init__.py: Fix attribute check #862
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue of registering groups ( #854 ) I changed the following:
Use an empty dict as a default for
default_hints
Use
hasattr()
instead of bare object access/checkWhen
default_hints
is passed to theStatus
object instanciation the following errorFatal Error - ValueError(Additional arguments are invalid if 'module' is already an object)
is shown.This can be handled by excluding type of
i3pystatus.group.Group
in the check at L118 but I could not import the class due to:I could fix all imports but the import of
Status
which also showed the above error