-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: io: add multibit/bus variants of SDR and DDR #2105
build: io: add multibit/bus variants of SDR and DDR #2105
Conversation
Thanks @maass-hamburg for the different PRs! Would you mind explaining the use-cases in the PR to be able to review the PR having the use-cases in mind? |
@enjoy-digital
could be replaced with:
|
@enjoy-digital IMO the prefered way to go instead of this would be to have the regular SDR/DDR variants support longer lengths than 1, just like the migen |
@maass-hamburg: That's indeed what I also tought when having a first look at the PR. If it's too much work to do it for all vendor initially, we could also just have assert in implementations to only build for the supported cases. |
c76d099
to
5249e20
Compare
@enjoy-digital I implemented this now also for all of the other vendors, but in a generic way, which should function, but might not be the most efficient way for that platform. |
f71529d
to
061b0dc
Compare
expand variants of SDR and DDR to support more than one pin. Signed-off-by: Fin Maaß <[email protected]>
implement bus variants of SDR/DDR IO for efinix. Signed-off-by: Fin Maaß <[email protected]>
061b0dc
to
a5da61a
Compare
@enjoy-digital rebased it, due to conflicts |
@enjoy-digital please take a look, would be nice to get this merged soon. |
@maass-hamburg: Thanks, I try to do this soon. |
Thanks @maass-hamburg, this looks fine. I think we should be able to simplify things and just use for the following constructs: |
extend SDR/DDR variants to support Signals longer than 1. Signed-off-by: Fin Maaß <[email protected]>
check len after wrap, because len won't work on int and bool. Signed-off-by: Fin Maaß <[email protected]>
a5da61a
to
e7a55fa
Compare
@enjoy-digital I changed it. |
@maass-hamburg: Great, thanks. This looks fine. I'll just try to build some design with it and if OK, will merge. |
@maass-hamburg, this is merged. I had to do a few changes on top to avoid verilog slicing issues: 0bfaf39, e71e404 and 279b758. |
@enjoy-digital Thanks, I also started a PR regarding slicing in migen, that might help and reduce useless slices: m-labs/migen#299 |
now that enjoy-digital/litex#2105 is merged, we can simplify the SDR IO in the rmii phy. Signed-off-by: Fin Maaß <[email protected]>
now that enjoy-digital/litex#2105 is merged, we can simplify the SDR IO in the phy. Signed-off-by: Fin Maaß <[email protected]>
use multibit io, that was introduced in enjoy-digital/litex#2105 improve and simplify rx and tx Signed-off-by: Fin Maaß <[email protected]>
add bus variants of SDR and DDR, which
support more than one pin.