-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BP-1372: Bump all Stylelint package versions (and adjust related rule changes) #246
base: master
Are you sure you want to change the base?
BP-1372: Bump all Stylelint package versions (and adjust related rule changes) #246
Conversation
@@ -23,7 +23,7 @@ | |||
"stylelint-group-selectors": "^1.0.10" | |||
}, | |||
"peerDependencies": { | |||
"stylelint": "^16.10.0" | |||
"stylelint": "^16.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider adding the selector-pseudo-class-allowed-list& selector-pseudo-class-disallowed-list rules to our styling configuration? Since this rule has been extended in the newest version of our stylint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...And even if we don't want it, we still miss it in our config, so - yes.
stylelint-scss package: function-color-channel was added in 6.8.0 but is missing in our config |
@@ -23,7 +23,7 @@ | |||
"stylelint-group-selectors": "^1.0.10" | |||
}, | |||
"peerDependencies": { | |||
"stylelint": "^16.10.0" | |||
"stylelint": "^16.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...And even if we don't want it, we still miss it in our config, so - yes.
https://enigmatry.atlassian.net/browse/BP-1372