Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-1372: Bump all Stylelint package versions (and adjust related rule changes) #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Cvetanovic
Copy link
Contributor

@@ -23,7 +23,7 @@
"stylelint-group-selectors": "^1.0.10"
},
"peerDependencies": {
"stylelint": "^16.10.0"
"stylelint": "^16.12.0"
Copy link
Contributor

@jovana-marceta jovana-marceta Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider adding the selector-pseudo-class-allowed-list& selector-pseudo-class-disallowed-list rules to our styling configuration? Since this rule has been extended in the newest version of our stylint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...And even if we don't want it, we still miss it in our config, so - yes.

@typhoon41
Copy link
Member

stylelint-scss package: function-color-channel was added in 6.8.0 but is missing in our config
stylelint-use-nesting package: csstools/use-nesting not configured at all in our config
stylelint package: media-query-no-invalid rule missing...please check if any other rule is missing (compare rule list from website and our config)

@@ -23,7 +23,7 @@
"stylelint-group-selectors": "^1.0.10"
},
"peerDependencies": {
"stylelint": "^16.10.0"
"stylelint": "^16.12.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...And even if we don't want it, we still miss it in our config, so - yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants