Open
Conversation
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXXX
Refs: #3108
Description
@endo/memoizeis a tiny package that had depended on'ses'only forharden. It is a great example of why we factoredhardenout into an importable@endo/harden. The PR changes@endo/memoizeto depend directly onendo@hardenrather thanses.Security Considerations
@endo/harden enables non-protecting hardens, but only when protection is off in general. @endo/memoize only provides its strong guarantees when @endo/harden is fully protecting. This is all consistent, so I would say:
No weakening of security.
Scaling Considerations
A bit. It means other packages can depend on @endo/memoize without bringing in all of ses.
Documentation Considerations
none
Testing Considerations
Compatibility Considerations
none
Upgrade Considerations
none