Don't install BIOS GRUB in sd-boot images #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In essence this reverts commit 074ade3. The device this was intended to support never went into production. In addition, config/schema.ini rejects this value for `[image] partition_table`! https://phabricator.endlessm.com/T34775
systemd-boot is EFI-only. If we use systemd-boot on an image, we actively do not want the system to be BIOS-bootable. (And the installed BIOS GRUB doesn't actually work on these images anyway.) https://phabricator.endlessm.com/T34775
This partition was never useful and is now unused. We will find out which of our tools assume a 3-partition disk image... https://phabricator.endlessm.com/T34775
|
Scratch build running at https://ci.endlessos.org/job/image-build-amd64/30438 |
|
Tested that image in 2 ways:
|
dbnicholson
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-boot is EFI-only. If we use systemd-boot on an image, we
actively do not want the system to be BIOS-bootable. (And the installed
BIOS GRUB doesn't actually work on these images anyway.)
On sd-boot images, don't install any BIOS bootloader and don't create a BIOS Boot partition.
In addition, drop code for the long-unused
crospartition layout.https://phabricator.endlessm.com/T34775