image: Chown Kolibri and Endless Key data #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpfiles.d configuration is provided for both that changes ownership to kolibri:kolibri for both at runtime. However, if there's an overlayfs on /var like there is when booting an ISO, all the files are copied to the upper tmpfs. That's likely to OOM the system when either is filled with preloaded data. One possibility is to run the tmpfiles.d configuration here. For simplicity, we just run `chown` here. For Kolibri, a separate hook is added since the content generation is split across 3 hooks. https://phabricator.endlessm.com/T35498
wjt
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpfiles.d configuration is provided for both that changes ownership to kolibri:kolibri for both at runtime. However, if there's an overlayfs on /var like there is when booting an ISO, all the files are copied to the upper tmpfs. That's likely to OOM the system when either is filled with preloaded data.
One possibility is to run the tmpfiles.d configuration here. For simplicity, we just run
chownhere. For Kolibri, a separate hook is added since the content generation is split across 3 hooks.https://phabricator.endlessm.com/T35498
I haven't run this at all, but I believe it's correct.