Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: Add hook to customize metrics server URLs #164

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

dbnicholson
Copy link
Member

Allow configuring the metrics server URLs so that 3rd parties deploy the Endless metrics stack they can build images to use them out of the box.

https://phabricator.endlessm.com/T35420

@dbnicholson dbnicholson requested a review from wjt May 29, 2024 18:05
@dbnicholson dbnicholson marked this pull request as draft May 29, 2024 18:06
@dbnicholson
Copy link
Member Author

I'm marking this as a draft since we may not want to bother with the eos-phone-home dropin if endlessm/eos-phone-home#18 is merged.

@cassidyjames
Copy link
Member

cassidyjames commented May 29, 2024

endlessm/eos-phone-home#18 indeed seems cleaner, so I think I prefer that unless there's a good reason to do it this way.

Edit: ah, but we may want to merge this first since it adds the metrics_server_url and
activation_server_url keys to the config, then we can update the hook itself to write the config file, or…?

hooks/image/50-metrics-urls Outdated Show resolved Hide resolved
Allow configuring the metrics server URLs so that 3rd parties deploy the
Endless metrics stack they can build images to use them out of the box.

https://phabricator.endlessm.com/T35420
@dbnicholson dbnicholson marked this pull request as ready for review May 30, 2024 14:26
@dbnicholson
Copy link
Member Author

I hate the idea of editing an INI file with sed and echo so I had a brief foray into "proper" editing using configparser. But it turns out that it's write method is fairly barebones, so I scrapped it. This should be good enough knowing that both files only have a single global section.

@wjt wjt merged commit 27ff146 into master May 30, 2024
2 checks passed
@wjt wjt deleted the T35420-metrics-urls branch May 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants