defaults: add Decibels & Music #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can/should this be just under `apps_add` since Decibels will handle opening audio files? https://phabricator.endlessm.com/T32696
wjt
requested changes
Mar 26, 2024
1 task
|
@wjt ah, I saw Totem there and thought Decibels served a similar purpose; without it, I guess audio files will just open in Totem? I agree Music should replace Rhythmbox in |
wjt
approved these changes
Mar 26, 2024
| @@ -502,7 +503,7 @@ apps_add = | |||
| org.gimp.GIMP | |||
| org.gnome.Cheese | |||
| org.gnome.Gnote | |||
| org.gnome.Rhythmbox3 | |||
| org.gnome.Music | |||
There was a problem hiding this comment.
Very convenient that they fall in the same place in the sort order!
| @@ -466,6 +466,7 @@ apps_add_mandatory = | |||
| [flatpak-remote-flathub] | |||
| repo_file = https://dl.flathub.org/repo/flathub.flatpakrepo | |||
| apps_add_mandatory = | |||
| com.vixalien.decibels | |||
There was a problem hiding this comment.
Yes, on second thoughts, your line of reasoning makes sense: being able to play audio files is essential functionality, so decibels should go here; while having a music library app is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T32696