create-iso: Use non-branched endless-installer.exe #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In effect, this reverts 4a167ae and a2f1eb4. In the past, the Endless Installer for Windows was under active development, with corresponding changes in the OS. To be able to e.g. test the installer from within an ISO built by our infrastructure before releasing the installer changes to the public, we had to fetch the installer from a branched URL. Now the installer is essentially dead, this just adds extra steps to our release process for no benefit. Fetch from an unbranched URL. I stand by the TODO I wrote in 977b96d though it seems vanishingly unlikely we will ever do that. https://phabricator.endlessm.com/T35105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In effect, this reverts 4a167ae and
a2f1eb4.
In the past, the Endless Installer for Windows was under active
development, with corresponding changes in the OS. To be able to e.g.
test the installer from within an ISO built by our infrastructure before
releasing the installer changes to the public, we had to fetch the
installer from a branched URL.
Now the installer is essentially dead, this just adds extra steps to our
release process for no benefit. Fetch from an unbranched URL.
I stand by the TODO I wrote in 977b96d
though it seems vanishingly unlikely we will ever do that.
https://phabricator.endlessm.com/T35105