Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Install python3-dev package in buildroot #139

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

dbnicholson
Copy link
Member

If the build needs to install a Python package from PyPI (like hooks/image/60-kolibri-content), it's possible that it will need to be built natively from source if there are no binary wheels available for the current Python version. That fails if the Python development environment isn't available.

https://phabricator.endlessm.com/T35125

If the build needs to install a Python package from PyPI (like
hooks/image/60-kolibri-content), it's possible that it will need to be
built natively from source if there are no binary wheels available for
the current Python version. That fails if the Python development
environment isn't available.

https://phabricator.endlessm.com/T35125
Copy link
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but I can never remember: why do we install packages from PyPI rather than using the Flatpak of Kolibri that we have just installed into the image?

@dbnicholson
Copy link
Member Author

This seems fine, but I can never remember: why do we install packages from PyPI rather than using the Flatpak of Kolibri that we have just installed into the image?

I've never tried it myself, but last time JP tried it it failed for him. I agree that would be a lot better.

For Endless Key it's a bit simpler since it can manage the plugins itself at runtime and all that's needed is Kolibri to drive the content import during the image build. I believe the Kolibri flatpak needs the plugins to be enabled, though.

@dylanmccall
Copy link
Contributor

Yeah, it would be nice to get it using Kolibri from the flatpak. But based on the two attempts to do that so far (mine, and JP's) that's probably a few days of hair pulling :b I think it's only a little more bother to fine-tune the way we preload content, such that the image has a content directory and a manifest file, instead of a content directory and a Kolibri database. Much of the complexity here comes from needing to have approximately the same Kolibri as in the flatpak, and the best thing is if ( 🌈 some day 🍯 ) we stop needing to do that.

@dylanmccall dylanmccall merged commit 96489cc into master Dec 9, 2023
2 checks passed
@dylanmccall dylanmccall deleted the T35125-python-dev branch December 9, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants