Alternative brightness control option using brightnessctl #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add brightnessctl option and pass in step sizes as arguments
Add brightnessctl option and add arguments for brightness/volume step size
|
it needs some more details on the 2 commits about what exactly the changes does and why they should be added, this is a specified generic setup, defaults should be working on common devices without the need to change. |
* Step size now passed in as an argument, rather than set within the script itself. This way it can be changed from i3conf. * Added brightness control method using backlightctl, as many users including myself cannot get xorg-xbacklight to work on our devices. (See below links) 1) https://forum.endeavouros.com/t/brightness-control-keys-not-working-on-my-i3wm-install/18064/2 2) https://forum.endeavouros.com/t/issues-with-brightness-control-on-i3wm-in-built-keys-shortcuts/42693/2 3) https://forum.endeavouros.com/t/laptop-brightness-keys-f3-f4-doesnt-work/44866/8
* Add brightnessctl option for brightness control * Add arguments for brightness/volume step size
* Step size now passed in as an argument, rather than set within the script itself. This way it can be changed from i3conf. * Added brightness control method using backlightctl, as many users including myself cannot get xorg-xbacklight to work on our devices. (See below links) * Removed duplicate text at the top of volume_brightness.sh * Add brightnessctl option in i3config * Add arguments for brightness/volume step size in i3config 1) https://forum.endeavouros.com/t/brightness-control-keys-not-working-on-my-i3wm-install/18064/2 2) https://forum.endeavouros.com/t/issues-with-brightness-control-on-i3wm-in-built-keys-shortcuts/42693/2 3) https://forum.endeavouros.com/t/laptop-brightness-keys-f3-f4-doesnt-work/44866/8
|
The latest commit has more details in the commit message. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can only control my ASUS TUF laptop using backlightctl, so I edited volume_brightness.sh and the i3 config to include a backlightctl option. While I was there, I made volume/brightness step size an argument for volume_brightness.sh so it can be set right in the i3 config.
If someone could test that the original method is still functional on their device, that'd be great.
This is my first ever PR so feedback is very much welcome :)