Move dwindle config "no gaps when only" to workspace rules #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated hyprland today and noticed that I was getting an error/red error message at the top of the screen as I had
no_gaps_when_only = 1uncommented in the dwindle config section ofgeneral.confTurns out that setting has been removed, and the new method to achieve this setting is using workspace rules.
The rules I added were taken from a recent update to the Hyprland default/example config (hyprwm/Hyprland@8e51a36). Since there don't seem to be any existing workspace rules, I added a section for them to the rules file, and then added the example code verbatim (with one extra comment line explaining that it replaces the old dwindle config setting).
As the
no_gaps_when_only = 1is commented out in the current dots-hyprland general.conf file, I have kept the "smart gaps" lines commented in their new position, so this shouldn't change any default functionality. My commit just removes a commented config setting that no longer exists and adds a commented replacement for it.