Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Add docs and attribution for creator and maintainer #2405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

📝 Add docs and attribution for creator and maintainer #2405

wants to merge 3 commits into from

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Aug 1, 2024

Summary

📝 Add docs and attribution for creator and maintainer.

I think attribution is very well deserved and it would be nice to add a bit of visibility, to highlight the people behind Uvicorn. 🙇

image

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

tomchristie
tomchristie approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiangolo I think this looks fantastic. ✨
Thanks so much for the suggestion. ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@Kludex Kludex Awaiting requested review from Kludex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiangolo @tomchristie