Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stacklevel=2 to Client warnings #3294

Closed
wants to merge 2 commits into from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Sep 3, 2024

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

see this rule: https://docs.astral.sh/ruff/rules/no-explicit-stacklevel/

without stacklevel=2, warnings show on lines in httpx module, not in user code, where Client is created

@trim21
Copy link
Contributor Author

trim21 commented Sep 4, 2024

I also recommend httpx enable this ruff rule

@tomchristie
Copy link
Member

Thanks for this. Now obsoleted both of these occurrences in version-1.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants