Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: suppport IDNA2003 #3284

Closed
wants to merge 7 commits into from
Closed

feat: suppport IDNA2003 #3284

wants to merge 7 commits into from

Conversation

waketzheng
Copy link

Summary

Closes #3229

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@waketzheng waketzheng changed the title Feat idna2003 feat: suppport IDNA2003 Aug 27, 2024
T-256
T-256 reviewed Aug 27, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
httpx/_urlparse.py Outdated Show resolved Hide resolved
@tomchristie
Copy link
Member

We don't want to include a strict_idna parameter.
Less configuration rather than more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-256 T-256 T-256 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IDNA2003
3 participants
@waketzheng @tomchristie @T-256