[fix] Use proxy ssl context consistently #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Miss clicked to closed by mistake |
|
@tomchristie could you please take a look at this when you have a chance |
|
My apologies for the delayed review. Yes, we do need to pass the SSL context of the proxy to the HTTPCore pool. |
karpetrosyan
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SSL context from httpx.Proxy is not used consistently across the proxy connections created in in HTTP transport this PR changes that. Haven't really added a test as I haven't found another test that check for proxy with custom ssl context but would love guidance around if/where one should be added here.
No specific documentation seems to be needed to be updated this should just get the api consistent.
Checklist