-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle async cancelled error explicitly #811
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need to change in both httpcore/_async
and httpcore/_sync
and ensure them match.
As what's said in #806, I think this could be ignored in |
Is this solution respects such cases?
|
No, #812 will respect. Actually this PR can expose why current cleanup system is not well implemented. |
Do we want to marge this PR when we know it will break programs that handle |
Yes. because still some of cleanups doesn't handle
And also notice few |
Should we consider convert exception handlings in #811 (comment) to |
Co-authored-by: Kar Petrosyan <[email protected]>
Summary
Discussed in #805
Checklist