Skip to content

Make locatefile configurable + missing exported types #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinRenou merged 2 commits into from
Feb 18, 2025
Merged

Make locatefile configurable + missing exported types #47

martinRenou merged 2 commits into from
Feb 18, 2025

Conversation

@martinRenou
Copy link
Collaborator

@martinRenou martinRenou commented Feb 18, 2025

No description provided.

@martinRenou martinRenou added the bug Something isn't working label Feb 18, 2025
@martinRenou
Copy link
Collaborator Author

martinRenou commented Feb 18, 2025

I'm not quite sure about this change. Will keep as a draft for now.

@martinRenou martinRenou marked this pull request as draft February 18, 2025 12:45
@martinRenou
Copy link
Collaborator Author

martinRenou commented Feb 18, 2025 •
edited
Loading

Since this will make workers not registered with {type: 'module'} fail, we should consider this a breaking change and release 6.0.0 with this.

@martinRenou martinRenou marked this pull request as ready for review February 18, 2025 13:04
@martinRenou martinRenou changed the title Fix wasm import Make locatefile configurable + missing exported types Feb 18, 2025
@martinRenou martinRenou merged commit ba51992 into emscripten-forge:main Feb 18, 2025
1 check passed
@martinRenou martinRenou deleted the meta-urlg branch February 18, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@martinRenou