[FETCH] Document body parameter type as BodyInit in send()#26265
Open
jeantimex wants to merge 2 commits intoemscripten-core:mainfrom
Open
[FETCH] Document body parameter type as BodyInit in send()#26265jeantimex wants to merge 2 commits intoemscripten-core:mainfrom
jeantimex wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
brendandahl
reviewed
Feb 14, 2026
| /** | ||
| * Sends the request. | ||
| * @param body The body of the request. | ||
| * @param {BodyInit|null} body The body of the request. |
Collaborator
There was a problem hiding this comment.
I don't think we use any TS specific types in our JS docs currently. Is this solving an issue for you or could we use a generic JS type to describe it instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the JSDoc type definitions for the send() method in the internal Fetch-based XHR implementation. Currently, the body parameter lacks a specific type.