Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat add map store #1

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Feat add map store #1

merged 2 commits into from
Feb 27, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 27, 2024 •
edited
Loading

  • Add map as avro store, and use it as default.
  • Changed to store type aliases as type's full name index, so the type store map (or dict) is less bloated.

thalesmg
thalesmg approved these changes Feb 27, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
src/avro_schema_store.erl Outdated Show resolved Hide resolved
thalesmg
thalesmg approved these changes Feb 27, 2024
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@zmstone
refactor: index types as aliases
805edac 
prior to this change, the type is copied to each alias making the
term bloated.
changed to store alias as 'index', meaning when look up,
it needs to first resolve the type full-name and then look up again.
@zmstone zmstone merged commit 2389b7b into emqx:master Feb 27, 2024
1 check passed
@zmstone zmstone deleted the feat-add-map-store branch February 28, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmstone @thalesmg