feat(dev/v4.4-bc-qiankun):add qiankun for emqx-dashboard as subapp #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljemq
force-pushed
the
dev/v4.4-bc-qiankun
branch
from
e3c5781 to
7b7013b
Compare
Kinplemelon
reviewed
Oct 10, 2022
src/common/forToBeSubApp.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| export const SING_NODE_VALUE = 'single-node' | |||
| export const isSingNode = (node) => node === SING_NODE_VALUE | |||
|
|
|||
There was a problem hiding this comment.
Remove these two lines, useless here
Kinplemelon
reviewed
Oct 10, 2022
src/common/http.js
Outdated
| @@ -149,6 +183,7 @@ axios.interceptors.response.use((response) => { | |||
| let error = '' | |||
| let selfError = '' | |||
| if (typeof res === 'object') { | |||
| console.log(res, 'res') | |||
Kinplemelon
reviewed
Oct 10, 2022
src/components/LeftBar.vue
Outdated
| @@ -221,6 +242,18 @@ export default { | |||
| ], | |||
| }, | |||
| ] | |||
| if (path.startsWith('/emqxDashBoard')) { | |||
There was a problem hiding this comment.
Why not use the isSubApp variable to judge here?
Kinplemelon
reviewed
Oct 10, 2022
| childrenPath[5] = projectId | ||
| childrenPath[6] = deployId | ||
| childrenPath[7] = deployType | ||
| children.path = childrenPath.join('/') |
Kinplemelon
reviewed
Oct 10, 2022
| @@ -52,6 +60,9 @@ module.exports = { | |||
| }, | |||
| }, | |||
| }, | |||
| headers: { | |||
| 'Access-Control-Allow-Origin': '*', | |||
There was a problem hiding this comment.
I wonder why there need to add this
There was a problem hiding this comment.
|
sooooo many files, thank you for you updated the configuration of eslint and replace path with name |
Kinplemelon
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base branch is dev/v4.4 and change router from path to name