feat(quic): quic fine tune #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
reviewed
Oct 7, 2024
| @@ -691,8 +694,8 @@ connect(Parent, N, PubSub, Opts) -> | |||
| undefined when TopicPayloadRend == undefined -> | |||
| erlang:send_after(RandomPubWaitMS, self(), publish); | |||
| undefined -> | |||
| maps:foreach(fun(TopicName, #{name := TopicName}) -> | |||
| erlang:send_after(RandomPubWaitMS, self(), {publish, TopicName}) | |||
There was a problem hiding this comment.
I think the use of the random wait was intentional: to stagger publishing over a wider period of time instead of a huge simultaneous burst.
There was a problem hiding this comment.
This is for topic payload --topics-payload option, we don't want publisher send pkts immediately(regardless of random wait) after connect.
maybe change it to
RandomPubWaitMS + DelayMs ?
qzhuyan
force-pushed
the
dev/william/quic-fine-tune
branch
from
deb45ad to
d5ab65d
Compare
|
Also fixed a dumb bug relates to |
thalesmg
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change:
old
--quicnow must come with--quic trueas arg type changes.new
--quic fine_tune.etermis supported for fine tune the quic conn and quic ctrl stream.