Dev/william/unbreakable reconn #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/unbreakable-reconn
branch
from
b66ec46 to
e680eb9
Compare
qzhuyan
commented
Nov 17, 2023
| @@ -714,6 +714,7 @@ loop(Parent, N, Client, PubSub, Opts) -> | |||
| {connected, _Props} -> | |||
| inc_counter(reconnect_succ), | |||
| IsSessionPresent = (1 == proplists:get_value(session_present, emqtt:info(Client))), | |||
| %% @TODO here we do not really check the subscribe | |||
| PubSub =:= sub andalso not IsSessionPresent andalso subscribe(Client, N, Opts), | |||
There was a problem hiding this comment.
need some ideas how to handle this if resubscribe fail.
zmstone
reviewed
Nov 17, 2023
qzhuyan
force-pushed
the
dev/william/unbreakable-reconn
branch
from
e680eb9 to
1cbd5ed
Compare
zmstone
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.