fix(cli): optimize client id gen logic for bench #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysfscream
added
enhancement
Red-Asuka
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
The
simulatecommand does not support fixed client IDs. It automatically appends an index to prevent duplication, which can cause issues when a fixed client ID is required.What is the new behavior?
The
simulateand other bench commands now support fixed client IDs. If the-cparameter is set to 1, the client ID will remain unchanged unless it contains a%iplaceholder. This allows for more flexible client ID configurations, which are especially useful for scenarios like sending data to other platforms.Does this PR introduce a breaking change?