fix(cli): support more biarny type files #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysfscream
added
enhancement
Red-Asuka
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1806
What is the new behavior?
This pull request includes updates to the
cli/src/__tests__/utils/binaryFormats.test.tsandcli/src/utils/binaryFormats.tsfiles to expand the list of supported and unsupported binary formats for MQTT. The changes also include improvements to the test cases to handle format categories and case sensitivity.Updates to supported and unsupported formats:
cli/src/__tests__/utils/binaryFormats.test.ts: Expanded the list of supported and unsupported binary formats, including new categories such as Network & Protocol formats, Database formats, IoT & Device formats, and more.cli/src/utils/binaryFormats.ts: Added new binary formats to thesupportedBinaryFormatsForMQTTarray, including network protocol formats, database formats, and custom protocol & data formats.Improvements to test cases:
cli/src/__tests__/utils/binaryFormats.test.ts: Enhanced test cases to check for case sensitivity and to handle format categories correctly.Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information