feat(icons): integrate unplugin-icons for enhanced icon management #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-Asuka
added
refactor
ysfscream
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the integration of
unplugin-iconsacross theapps/desktopandapps/webprojects, as well as the removal of custom icon font definitions in favor of this new approach. The changes include updates to configuration files, package dependencies, and type definitions.Integration of
unplugin-icons:apps/desktop/electron.vite.config.ts: Added imports forFileSystemIconLoader,IconsResolver, andIcons, and configuredIconsResolverandIconsplugins to use custom icon collections. [1] [2]apps/web/vite.config.ts: Added imports forFileSystemIconLoader,IconsResolver, andIcons, and configuredIconsResolverandIconsplugins to use custom icon collections. [1] [2]Package dependencies:
apps/desktop/package.json: Addedunplugin-iconsas a dependency.apps/web/package.json: Addedunplugin-iconsas a dependency.packages/ui/package.json: Addedunplugin-iconsas a dependency.Type definitions:
apps/desktop/tsconfig.web.json: Addedunplugin-icons/types/vueto thetypesarray.apps/web/tsconfig.app.json: Addedunplugin-icons/types/vueto thetypesarray.Removal of custom icon font definitions:
packages/ui/src/assets/fonts/iconfont.css: Removed the entire custom icon font definitions file.These changes collectively enhance the maintainability and scalability of icon management within the project by leveraging the
unplugin-iconspackage.