Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync topic tree from connection #1800

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Sync topic tree from connection #1800

merged 3 commits into from
Nov 13, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Nov 11, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The data is currently synchronized in one direction, Topic Tree -> Connections.

What is the new behavior?

image image

This pull request includes several updates to the topic node and message services, as well as some minor changes to the SCSS and translation files. The main focus is on refactoring and enhancing the functionality related to topic tree structures and message statistics.

Enhancements to Topic Node and Message Services:

  • Added getMessageTopicNodeStats method to MessageService to fetch connection info and topic statistics.
  • Refactored TopicNodeService to improve the handling and retrieval of topic tree structures, including methods like getTree, updateTopicNodes, and clearTree. [1] [2] [3] [4] [5] [6] [7]
  • Introduced utility functions buildTopicTreeFromStats and flattenTopicTree in topicTree.ts for constructing and flattening topic trees.

Minor Changes:

  • Added a new text color class .text-tips in atom.scss.
  • Removed unused import in ImportScript.vue.
  • Added new translations for syncing topic trees and connections in connections.ts and viewer.ts. [1] [2]

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream changed the title feat(desktop): time range support on traffic monitor feat(desktop): time range support on traffic monitor (WIP) Nov 11, 2024
@ysfscream ysfscream changed the title feat(desktop): time range support on traffic monitor (WIP) Sync topic tree from connection (WIP) Nov 11, 2024
@ysfscream ysfscream requested a review from Red-Asuka November 12, 2024 14:45
@ysfscream ysfscream self-assigned this Nov 12, 2024
@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature desktop MQTTX Desktop labels Nov 12, 2024
@ysfscream ysfscream added this to the v1.11.1 milestone Nov 12, 2024
@ysfscream ysfscream marked this pull request as ready for review November 12, 2024 14:46
@ysfscream ysfscream changed the title Sync topic tree from connection (WIP) Sync topic tree from connection Nov 13, 2024
@Red-Asuka Red-Asuka merged commit e41b139 into main Nov 13, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch November 13, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants