Add Value and this[string name] to PdfItem.
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… read. Add some missing implementation method for CSequence and fixed it's Copy() method.
…or this[string] in PdfDictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
Valueproperty toPDFItemeliminates the need to cast an item toPDFReferenceand the need to check if it's actual reference (I believe in most scenarios the API users don't care if it's a reference or not).Adding
this[string]eliminates both, the need to use.Elementsproperty and need of casting an item toPDFDictonaryat every step.This greatly simplifies traversing the objects trees as you can see in below image.
On both sides the code do the same thing.
Please ignore the first commit as it was from previous PR. Tell me what you think about that?