miscellaneous fixes #143
Merged
miscellaneous fixes #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linked against older version of the WinSock library (wsock32 instead of ws2_32); this was actually fine for the editor itself, but not sufficient for the example application
This made it impossible to load a new music file if decoding failed once. Also fixed some typos.
The code was missing all the necessary wide-char <-> multibyte conversions. So it only saved the first character of the file name, and loading only didn't crash because of sheer luck.
especially on Linux, where the console is an important channel of interaction with the program, the many lines of log were really too much clutter
|
Awesome! Thanks a bunch for these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common fixes:
Windows specific fixes:
Linux specific fixes:
build fixes/features: