Fix close embed have Rust Fatal error for IO Safety violation #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced unsafe raw file descriptor usage with safe cloning of the socket for both TCP and Unix listeners. This change enhances safety and maintains functionality.
Simplified the creation of TCP and Unix listeners by directly returning the result of the socket cloning operation, enhancing code clarity and maintainability.
Member
|
Thanks for your contribution. This is now superseded by #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
SocketHolder::as_tcp_listenerandSocketHolder::as_unix_listenerto usetry_clone()instead of constructing listeners withfrom_raw_fd(as_raw_fd()).Motivation
Using
TcpListener::from_raw_fd(self.socket.as_raw_fd())(or the equivalent for UnixListener) takes ownership of the same raw file descriptor that self.socket already owns.This can lead to double-closing the same FD once both objects are dropped, causing runtime aborts such as:
fatal runtime error: IO Safety violation: owned file descriptor already closedBenefits
Memory/FD safety: each listener now owns a duplicated file descriptor, preventing double-close issues.
Eliminates unsafe: removes the need for unsafe blocks.
Minimal overhead: dup() system call cost is negligible compared to network I/O.
Notes
This change only affects FD ownership semantics. Runtime behavior of the listeners remains the same, except that it avoids UB/crashes when objects are dropped in different orders.
Related to #681