Added support for URLs with placeholder arguments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rack/test. Fixed this by adding the gem to the Gemfile in the test group and requiring the gems in that group in spec/spec_helper.rb. Also fixed the rake/rdoctask deprecation warning by adding the rdoc gem to the gem file and requiring rdoc/task in the Rakefile.
|
|
||
| options_used = Set.new | ||
|
|
||
| options.each_pair do |placeholder_name, value| |
There was a problem hiding this comment.
There's a bug here - method url_for sets options to nil unless options was passed in. So if you don't pass in the optional parameter options you get "undefined method each_pair for nil:NilClass". BTW - the bug above is present in the version obtained from rubygems.org via 'gem install sinatra-url-for"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sinatra, you can specify a URL pattern handler such as /object/:id that will match URLs like /object/1 or /object/5.
I added support for this type of URL to be specified in the URL argument to url_for. If url_for's options argument has a key that equals the placeholder, the value associated with that key will be substituted into the url and that argument is removed from the options.
I added 2 rspec examples that show how this works.