Test for, and explicitly support, two-form call with existing options…

… hash

lib/sinatra/url_for.rb

@@ -25,6 +25,11 @@ module UrlForHelper
     # See README.rdoc for a list of some of the people who helped me clean
     # up earlier versions of this code.
     def url_for url_fragment, mode=nil, options = nil
+      if mode.is_a? Hash
+        options = mode
+        mode = nil
+      end
+
       if mode.nil?
         mode = :path_only
       end

spec/url_for_spec.rb

@@ -13,6 +13,11 @@
   url_for params[:url], params[:mode], params[:options]
 end
 
+get "/nomode" do
+  content_type "text/plain"
+  url_for params[:url], params[:options]
+end
+
 describe Sinatra::UrlForHelper do
   include Rack::Test::Methods
 
@@ -68,4 +73,11 @@ def app
     last_response.should be_ok
     last_response.body.should == "/foo?return_to=http%3A%2F%2Fexample.com%2Fbar%3Fx%3Dy"
   end
+
+  it "should handle not being passed a mode" do
+    get "/nomode", :url => "/foo", :options => { :x => "y" }
+
+    last_response.should be_ok
+    last_response.body.should == "/foo?x=y"
+  end
 end