Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common panels #5659

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Common panels #5659

wants to merge 12 commits into from

Conversation

sharky98
Copy link

⚠️ This would be a breaking change, since use must import the trait to use the methods transfered to the traits.

sharky98 added 12 commits January 29, 2025 22:39
@sharky98
partial commit
46d88fe 
Merged the sides.
Merged the panel options.

Started panel shows
@sharky98
completed the refactoring into a single panel struct
69eeab0
@sharky98
answering todo
e060403
@sharky98
remove unused vars
18b6e70
@sharky98
prepare to incorporate into panel.rs
03f10d8
@sharky98
modify enum Side to combine both vertical and horizontal sides & re…
c4464b5 
…move TopBottomSide

NOTE: Non-working commit
@sharky98
add PanelSizer to abstract some sizing calculations from the show m…
d716d38 
…ethods

NOTE: Non-working commit
@sharky98
add the new single Panel struct, with its complete impl
3e8a51e 
NOTE: Non-working commit
@sharky98
Convert all SidePanel with Panel
ae42de6 
following those steps:
1. Rename `egui::SidePanel` with `egui::Panel`.
2. Rename `width` with `size` in all chained methods.
    - `default_width()` to `default_size()`
    - `min_width()` to `min_size()`
    - `max_width()` to `max_size()`
    - `width_range()` to `size_range()`
    - `exact_width()` to `exact_size()`

if using `Panel::new()`, replace
- `Side::Left` with `Side::Vertical(VerticalSide::Left)`
- `Side::Right` with `Side::Vertical(VerticalSide::Right)`

NOTE: Non-working commit
@sharky98
Convert all TopBottomPanel with Panel, and remove reference to To…
3bff23f 
…pBottomPanel when both SidePanel and TopBottomPanel were mentioned.

following those steps:
1. Rename `egui::TopBottomPanel` with `egui::Panel`.
2. Rename `height` with `size` in all chained methods.
    - `default_height()` to `default_size()`
    - `min_height()` to `min_size()`
    - `max_height()` to `max_size()`
    - `height_range()` to `size_range()`
    - `exact_height()` to `exact_size()`

if using `Panel::new()`, replace
- `TopBottomSide::Top` with `Side::Horizontal(HorizontalSide::Top)`
- `TopBottomSide::Bottom` with `Side::Horizontal(HorizontalSide::Bottom)`

NOTE: Non-working commit
@sharky98
correcting compile errors
db99eb3 
- replace switch fn with closures in some places.
- integrate the switch fn inside the main switch.
- make sure lifetime are defined for PanelSizer.
- remove some `mut`, `&`, and `*` where they superfluous.
- wrongly called `ctx()` when it was a variable 🤦.
- cannot use `impl Trait` in a variable declaration type.
@sharky98
exposing Side publicly and renaming to PanelSide to avoid conflict
eca13ab
@sharky98 sharky98 mentioned this pull request Jan 30, 2025
Closed
1 task
@sharky98
Copy link
Author

Locally, all the tests passed (except those regarding git lfs and some images that the delta has nothing to do with my change (more or less text, etc.). The panel demo in egui_demo_app works as before. I did not saw anything different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce a Panel trait for SidePanel and TopBottomPanel
1 participant
@sharky98