copied_text function maintained in copy_text() until deletion
#5553
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5553-patch157 |
YgorSouza
reviewed
Dec 31, 2024
CHANGELOG.md
Outdated
| @@ -1230,7 +1230,7 @@ egui_extras::install_image_loaders(egui_ctx); | |||
| * [Tweaked the default visuals style](https://github.com/emilk/egui/pull/450). | |||
| * Plot: Renamed `Curve` to `Line`. | |||
| * `TopPanel::top` is now `TopBottomPanel::top`. | |||
| * `SidePanel::left` no longet takes the default width by argument, but by a builder call. | |||
| * `SidePanel::left` no longest takes the default width by argument, but by a builder call. | |||
|
why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My opinion is that it would be better to keep the current
copied_textwithout deprecating it, rather than creating a new function to identify or modify the content on the clipboard.at least until
copied_textis removed, thecopy_text()function should continue to usecopied_textin the same way it currently does.