Enable both CJS and ESM builds

[mansona]

While working on #10 I was testing out setting up scenario-tester in a non-built package (ember-cli-fastboot) and I wasn't able to get scenario-tester list to work because the code always expected commonJS.

here is a PR to ember-cli-fastboot that implements scenario-tester using this PR 👍 ember-fastboot/ember-cli-fastboot#919

I had another attempt at this PR in #11 but that wasn't very extensive. This one tests that you can easily define your scenarios in ESM and also TS files 👍

I tried to implement the multi-build as described in https://thesametech.com/how-to-build-typescript-project/ but it turns out that this is impossible because of the way that scenario tester works. We rely on module state to "collect" scarios when we're running scenario-tester list but if you define your scenarios in CJS then the ESM in the binary won't have the same module state 😞 I guess we could augment the CJS or the ESM output and make sure they use the same module state but that seems a bit extreme for me.

It turns out all i needed to do to get ESM and CJS working nicely was to use global scope for collecting the scenarios 🎉 I think this is safe to release as a minor

[ef4]

We rely on module state to "collect" scarios when we're running scenario-tester list but if you define your scenarios in CJS then the ESM in the binary won't have the same module state

We could decide to make the module state into global state if we want to solve that problem. It really is global state, as you discovered.

But it may also be ok to be ESM-only. Since scenario-tester is generally running as a command and not used as a library within other projects, I think the cost of switching isn't high. People would be forced to port their tests to native-ESM, but it shouldn't impose any restrictions on their actual library or application code.

You'll need to check on this though. I would suggest publishing an alpha of scenario-tester and trying to fully integrate it with embroider to see if it goes smoothly.

[NullVoxPopuli]

I want to find a lint for this, but I like having all the node builtins prefixed with node: -- good for differentiating between builtin and installed deps

[NullVoxPopuli]

is this a CJS TS? (I noticed there was an mjs -- porque no mts?)

[mansona]

the mjs is just for a test to make sure that it can explicitly be imported correctly from a mjs file. I don't have any opinion on ts or mts really 🤷 other than to say that this PR adds type: module to the package.json so it's not required (in the same way that you only need mjs when you're not using type: module in package.json)

[mansona]

I would suggest publishing an alpha of scenario-tester and trying to fully integrate it with embroider to see if it goes smoothly.

I guess we don't need an alpha if we just depend on a git dependency 🤔 that's what I'm doing in ember-fastboot/ember-cli-fastboot#919 and it's working fine 👍

[mansona]

i figured out how to make this work with both ESM and CJS support so we should be able to merge this soon 🎉